On Tue, 17 Nov 2009, Trent W. Buck wrote:

Ganesh Sittampalam <[email protected]> writes:

Generally when reviewing patches, I read them directly, perhaps have a
look at the source they apply to, and then decide that they're fine so
long as the tests pass. Actually keeping track of them between that
point and running the tests and pushing is a bit of a pain, and
there's a cognitive shift that feels quite disruptive.

Let me turn this around: how hard would it be to automate this, so that
patches that don't apply cleanly are automatically set to needs-amend?

Is it as simple as "apply --dry-run $attachment --repodir ..." within
the procmail script?

I think the difficulty here is uniquely identifying the correct attached bundle to apply, once a patch has been amended or similar.

This has been a bit of a source of concern to me from the point of view of human confusion too. Perhaps amendments should become fresh items in the tracker?

Ganesh
_______________________________________________
darcs-users mailing list
[email protected]
http://lists.osuosl.org/mailman/listinfo/darcs-users

Reply via email to