Petr Ročkai <[email protected]> added the comment: Daniel Dickison <[email protected]> writes: > Unless I wrote it incorrectly, the regression test in patch135 already checks > to > make sure _darcs/foo gets skipped: > > +touch _darcs/foo > +not darcs add _darcs/foo
This correctly tests add, but I suspect that add is not the only code that ever uses the boring filter in possibly fancy ways. I would expect a more thorough argument as for why this is safe, especially since the semantic change is easily avoided. The problem is that there are some ... creative ... pieces of code in darcs and it's not exactly good idea to change something that could have unintended consequences unless you are very sure that it won't. Eric could probably extol the virtues of conservativism much better than me though. Yours, Petr. __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch136> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
