Ganesh Sittampalam <[email protected]> added the comment: I've started reviewing this. Here are some partial comments. Petr, are you ok for me to any patches I'm already happy with (so long as darcs compiles/the testsuite passes, of course) while the rest of the review is still ongoing?
> Fri Feb 12 10:32:58 GMT 2010 Petr Rockai <[email protected]> > * Use a more canonic way to create empty hashed pristine. > Fri Feb 12 10:18:44 GMT 2010 Petr Rockai <[email protected]> > * Use a more canonic way to create empty hashed pristine in optimize (--upgrade). hardcoded "_darcs/pristine.hashed" is not a good standard, IMO > Fri Feb 12 10:17:51 GMT 2010 Petr Rockai <[email protected]> > * Cannot "darcs remove" non-existent files. What's the logic behind this? I agree that removing a file that's in pristine but not working is redundant, but I don't see why there should be a complaint. BTW while scratching my head at the remove code I found a bug which I'll raise as a separate ticket. > Thu Feb 11 00:14:35 GMT 2010 Petr Rockai <[email protected]> > * Re-implement setScriptsExecutable using Trees instead of Slurpies. > + tree <- expand =<< readPlainTree "." -- TODO filter out _darcs This TODO needs doing > Wed Feb 10 23:50:39 GMT 2010 Petr Rockai <[email protected]> > * Add a missing Functor constraint on ReadableDirectory TreeMonad instance. OK > Mon Feb 8 23:11:25 GMT 2010 Petr Rockai <[email protected]> > * Avoid use of SlurpDirectory in Commands.ShowFiles. > > +import Prelude hiding ( all ) > ... > +all <- ... Just call the variable a different name instead of breaking hiding standard Prelude functions in the rest of the module Rest looks ok. > Mon Feb 8 22:47:04 GMT 2010 Petr Rockai <[email protected]> > * Remove implementation of --store-in-memory, simplifying matcher code. This seems to be a live option. If you're dumping it, (a) there needs to be some discussion and (b) you haven't actually removed it properly, you're just ignoring it. > Mon Feb 8 18:20:27 GMT 2010 Petr Rockai <[email protected]> > * Replace Slurpy usage in Commands.Diff. OK > Mon Nov 16 08:02:25 GMT 2009 Petr Rockai <[email protected]> > * Remove unused force_replace_slurpy. OK __________________________________ Darcs bug tracker <[email protected]> <http://bugs.darcs.net/patch156> __________________________________ _______________________________________________ darcs-users mailing list [email protected] http://lists.osuosl.org/mailman/listinfo/darcs-users
