On Tue, Apr 27, 2010 at 04:28:59PM +0100, Eric Kow wrote:
> Requests
> --------
> 1. Please remove the tabs in the new import lines.
Done. I'll send out the amended patch soon.
> Perhaps you could persuade your text editor to switch to spaces-only
> mode for Haskell code?
No, but I smell a new feature here ;-) add some repository preference
that allows for checking sources against some regexps and add a big
red marker when using darcs whatsnew (similar to what darcs already
does with trailing whitespace).
> 2. Patch name could probably be 'resolve issue1769: etc'
> (but check to make sure it's really the same thing)
Changed (and I think it matches the feature request from twb).
> 3. Example for log matcher usage? (not obligatory, decided for
> yourself if it would help or just be noise)
Well, I added one, but I don't find those usage examples very useful.
YMMV.
> Also things to consider...
>
> 4. Look into the matcher name. Log seems fine, but just in case
> it may be useful to have another thought about it. Trent suggested
> 'description' in his issue1769.
Changed.
> 5. Haddocks for this module (follow-up patch.)
>
> 6. Check the user manual to see if it needs updating. (The manual says
> we have 6 primitive matchers whereas we would now have 8 with this
> patch, but are there other things to fix?).
I'll send a second patch that adds documentation for the two missing
matchers (hunk and description).
Ciao,
Kili
_______________________________________________
darcs-users mailing list
darcs-users@darcs.net
http://lists.osuosl.org/mailman/listinfo/darcs-users
