Hi Roman,
I've included the lens info for my particular case below.
But I guess for a lot of users, lensfun might often be out of date. And
they might blame darktable for it.
The nice thing about saving a user's selection is that it's
self-correcting. If the user choses a new one, their choice is updated.
Of course, maybe there's a better way to implement it than what I did.
In any case, here is my lens:
From a raw file (PEF) with my old camera:
exif_model=PENTAX K100D Super
exif_lens=smc PENTAX-DA 18-135mm F3.5-5.6 ED AL [IF] DC WR
sanitized=smc PENTAX-DA 18-135mm F3.5-5.6 ED AL [IF] DC WR
From a raw file (DNG) with my new camera:
exif_model=PENTAX K-50
exif_lens=smc PENTAX-DA 18-135mm F3.5-5.6 ED AL [IF] DC WR
sanitized=smc PENTAX-DA 18-135mm F3.5-5.6 ED AL [IF] DC WR
From the lensfun DB:
l->Maker=Pentax
l->Model=smc Pentax-DA 18-135mm f/3.5-5.6 ED AL IF DC WR
Let me know if you really want example files.
- Corey
On 07/19/2016 03:39 AM, Roman Lebedev wrote:
On Tue, Jul 19, 2016 at 9:32 AM, Corey <[email protected]> wrote:
Hi,
Hi.
I love darktable, but the lens I use the most is never recognized by
automatically by the lens correction module. The result is that I have to
manually select my lens for every photo, which not particularly enjoyable.
But why is it not automatically recognized?
Which lens? Which lensfun version?
Better upload sample raw file with that lens.
I thought this problem could be solved if the user's lens selection was
stored. That is, darktable could store the mapping from "camera+lens exif
string" to "camera+lens lensfun string" whenever the user selects a lens
explicitly. This could then be looked up if the lensfun search fails.
I've attached a patch file that implements this in a pretty simple way. It
seems to work for me (but I haven't done extensive testing).
The same thing could be done for the camera too, of course.
I'm curious to see what people think.
- Corey
Roman.
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to [email protected]
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to [email protected]
