On 7/20/2016 4:17 AM, Roman Lebedev wrote:
Let me know if you really want example files.
No need, i edited my ~/.config/darktable/library.db, and set
those maker/model/lens for one of the images.
And the good news is, it is autodetected properly with lensfun 0.3.2
(both darktable git master and 2.0.x)

Weird; it didn't work for me when I compiled dt from master...

So i'm not really sure there is a need for implementing such mapping in dt...
Also, not working lens autodetection is almost always exiv2/lensfun issue,
and with such mapping in dt
1. every one affected will have to set those mappings up for himself

Not sure I understand... if autodetection doesn't work, you have to set the mapping yourself (by choosing a lens). The workaround just lets you do it only once.

2. it is likely that since there is a workaround, the issue will never be
    reported upstream to be actually fixed

This is true with the change I made.

But probably fixable with a different implementation (like a "save my selection" button that also brings up a dialog box requesting the user alert lensfun.. or something).

3. for other software that also uses exiv2+lensfun, lens autodetection will
    still be broken.

Sure... but does it matter to a dt user? At the end of the day, I have to choose my lens for every photo, which means I don't use the module when I have hundreds of photos. Software updates haven't fixed this...


- Corey
___________________________________________________________________________
darktable developer mailing list
to unsubscribe send a mail to [email protected]

Reply via email to