Hi I am surprised to see that we cannot control the neighborhood parameter for the NLM algorithm (neither for the denoise non local mean, nor for the denoise profiled) from the GUI. I see in the code (denoiseprofile.c) this TODO that I don't understand: "// TODO: fixed K to use adaptive size trading variance and bias!" And just some lines after that: "// TODO: adaptive K tests here!" (K is the neighborhood parameter of the NLM algorithm).
In practice, I think that being able to change the neighborhood parameter allows to have a better noise reduction for one image. For example, choosing a bigger K allows to reduce the spotted aspect that one can get on high ISO images. Of course, increasing K increase computational time, but I think we could find an acceptable range that would still be useful. Is there any reason for not letting the user control the neighborhood parameter in the GUI ? Also, do you understand the TODOs ? I feel that we would probably get better denoising by fixing these, but I don't understand them. I can spend some time on these TODOs, or to add the K parameter to the interface if you think it is worth it (I think so but it is only my personal opinion), but I have to understand what the TODOs mean before Thank you for your help rawfiner ___________________________________________________________________________ darktable developer mailing list to unsubscribe send a mail to darktable-dev+unsubscr...@lists.darktable.org
