That PR, however, doesn't solve what Pascal is complaining about.
I'm working on the problem that Pascal mentions as well ('cause it has
annoyed the hell out of me as well).
However, there are things related to this that I wonder about... For
completeness, the following things would need to be saved with the
image (in dt_iop_clipping_params_t):
- aspect ratio (I'd like to save it as numerator and denominator
separately, for the sake of showing it in the GUI later on... or
would it be sane to save it in text form?)
- aspect ratio preset (int)
- aspect ratio preset flipped (bool)
That basically mimicks what is currently saved in darktablerc. Does
that seem sane?
Cheers,
Richard
P.S. Looking at the code, it sometimes seems to me it could do well
with a bit of refactoring... is that just me?
In message <CALXjwtPFTsNZ2=af6=jBL7kj110Nu8eEFVyZsLLuR_f8n=w...@mail.gmail.com>
on Wed, 16 Jan 2013 14:19:38 +0100, jeremy rosen
<[email protected]> said:
jeremy.rosen> yes makes sense...
jeremy.rosen>
jeremy.rosen>
jeremy.rosen> there is a PR related to that currently in github
jeremy.rosen> (https://github.com/darktable-org/darktable/pull/159)
jeremy.rosen>
jeremy.rosen> (not the same thing, but same area of code)
jeremy.rosen>
jeremy.rosen> if you are in that area, maybe you could review the PR and merge
it if
jeremy.rosen> it's good ? that would avoid useless merge conflicts later...
jeremy.rosen>
jeremy.rosen>
jeremy.rosen> On Wed, Jan 16, 2013 at 2:06 PM, Pascal Obry <[email protected]>
wrote:
jeremy.rosen> >
jeremy.rosen> > Today the aspect ratio is remembered from previous image and
this is
jeremy.rosen> > very annoying.
jeremy.rosen> >
jeremy.rosen> > Scenario:
jeremy.rosen> >
jeremy.rosen> > - change aspect ratio of image-1 to 3:2
jeremy.rosen> >
jeremy.rosen> > - change aspect ratio of image-2 to 1:1
jeremy.rosen> >
jeremy.rosen> > - go back to image-1, select clipping module, the aspect
jeremy.rosen> > ratio of the image is 1:1 loosing your previous crop!
jeremy.rosen> >
jeremy.rosen> > I think we should initialize the aspect ratio (in the GUI
combo) from
jeremy.rosen> > the actual crop of the image, this should be quite easy.
jeremy.rosen> >
jeremy.rosen> > Thoughts?
jeremy.rosen> >
jeremy.rosen> > --
jeremy.rosen> > Pascal Obry / Magny Les Hameaux (78)
jeremy.rosen> >
jeremy.rosen> > The best way to travel is by means of imagination
jeremy.rosen> >
jeremy.rosen> > http://v2p.fr.eu.org
jeremy.rosen> > http://www.obry.net
jeremy.rosen> >
jeremy.rosen> > gpg --keyserver keys.gnupg.net --recv-key F949BD3B
jeremy.rosen> >
jeremy.rosen> >
------------------------------------------------------------------------------
jeremy.rosen> > Master Java SE, Java EE, Eclipse, Spring, Hibernate,
JavaScript, jQuery
jeremy.rosen> > and much more. Keep your Java skills current with LearnJavaNow -
jeremy.rosen> > 200+ hours of step-by-step video tutorials by Java experts.
jeremy.rosen> > SALE $49.99 this month only -- learn more at:
jeremy.rosen> > http://p.sf.net/sfu/learnmore_122612
jeremy.rosen> > _______________________________________________
jeremy.rosen> > darktable-devel mailing list
jeremy.rosen> > [email protected]
jeremy.rosen> > https://lists.sourceforge.net/lists/listinfo/darktable-devel
jeremy.rosen>
jeremy.rosen>
------------------------------------------------------------------------------
jeremy.rosen> Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript,
jQuery
jeremy.rosen> and much more. Keep your Java skills current with LearnJavaNow -
jeremy.rosen> 200+ hours of step-by-step video tutorials by Java experts.
jeremy.rosen> SALE $49.99 this month only -- learn more at:
jeremy.rosen> http://p.sf.net/sfu/learnmore_122612
jeremy.rosen> _______________________________________________
jeremy.rosen> darktable-devel mailing list
jeremy.rosen> [email protected]
jeremy.rosen> https://lists.sourceforge.net/lists/listinfo/darktable-devel
------------------------------------------------------------------------------
Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery
and much more. Keep your Java skills current with LearnJavaNow -
200+ hours of step-by-step video tutorials by Java experts.
SALE $49.99 this month only -- learn more at:
http://p.sf.net/sfu/learnmore_122612
_______________________________________________
darktable-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-devel
