Le 16/01/2013 16:47, Richard Levitte a écrit : > I'm thinking about custom aspects. Say I fed in 851:315 (the facebook > cover image size)....
I see, we can enter aspect ratio manually! Didn't know :) Well, now I'm not sure whether we want to save this specific aspect ratio. Shouldn't it just display that we are using a "free" cropping. > In message <[email protected]> on Wed, 16 Jan 2013 16:04:09 +0100, > Pascal Obry <[email protected]> said: > > pascal> I've just pushed my fix for this. Please try it and tell me what you > think. > > I think that it's good for the presets. However, it doesn't support > custom aspect ratios (as noted above)... Right. I think custom aspect can be mapped to free aspect. Why isn't this good enough? > (also, I'm having this nagging thought of the person who just used the > "free" aspect, just wanted to adjust the size vertically, and ends up > having it automagically adjusted horizontally as well because his > previous crop was close enough to, say, 4:3) The close enough is an issue. Currently my epsilon is 0.01, we should probably use a lower value, what do you think? Of course we will always have the close enough issue, but well, a one pixel error isn't a big problem to me. Again, not forcing anything, just my thinking. Not even sure it is shared by all devs :) -- Pascal Obry / Magny Les Hameaux (78) The best way to travel is by means of imagination http://v2p.fr.eu.org http://www.obry.net gpg --keyserver keys.gnupg.net --recv-key F949BD3B ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
