In message <[email protected]> on Wed, 16 Jan 2013 16:56:51 +0100, Pascal Obry <[email protected]> said:
pascal> Le 16/01/2013 16:47, Richard Levitte a écrit : pascal> > I'm thinking about custom aspects. Say I fed in 851:315 (the facebook pascal> > cover image size).... pascal> pascal> I see, we can enter aspect ratio manually! Didn't know :) pascal> pascal> Well, now I'm not sure whether we want to save this specific aspect pascal> ratio. Shouldn't it just display that we are using a "free" cropping. Point is, if I've set this aspect ratio, it's pretty likely I'd like to have it if I go back to adjust. If it's suddenly "free", it will screw up the result I wanted. pascal> > I think that it's good for the presets. However, it doesn't support pascal> > custom aspect ratios (as noted above)... pascal> pascal> Right. I think custom aspect can be mapped to free aspect. Why isn't pascal> this good enough? See above. pascal> > (also, I'm having this nagging thought of the person who just used the pascal> > "free" aspect, just wanted to adjust the size vertically, and ends up pascal> > having it automagically adjusted horizontally as well because his pascal> > previous crop was close enough to, say, 4:3) pascal> pascal> The close enough is an issue. Currently my epsilon is 0.01, we should pascal> probably use a lower value, what do you think? Of course we will always pascal> have the close enough issue, but well, a one pixel error isn't a big pascal> problem to me. Again, not forcing anything, just my thinking. Not even pascal> sure it is shared by all devs :) The point I'm trying to make is that it's impossible for the program to know if the user's intent was to actually have a specific aspect ratio or a "free" aspect, just from the crop size. It can guess, and get close when the crop size matches a preset aspect ratio, it might get it well enough, but there's always the possibility that it guesses wrong. Cheers, Richard -- Richard Levitte [email protected] http://richard.levitte.org/ "Life is a tremendous celebration - and I'm invited!" -- from a friend's blog, translated from Swedish ------------------------------------------------------------------------------ Master Java SE, Java EE, Eclipse, Spring, Hibernate, JavaScript, jQuery and much more. Keep your Java skills current with LearnJavaNow - 200+ hours of step-by-step video tutorials by Java experts. SALE $49.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122612 _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
