hi, On Fri, Feb 1, 2013 at 9:18 PM, Eckhart Pedersen <[email protected]> wrote: > On 2013-02-01 03:40, johannes hanika wrote: > > hey, > > nice work, seems to run well telling by your video. i have some > stylistic remarks :) > > yellow stars, really? i strongly resent colors (and strong shapes) in > a ui around pictures.. at some point it doesn't look like the > collection of your photos but more like a bubblegum vending machine. > > > I used to resent the darktable approach of hiding everything until the mouse > is over a thumbnail, but I have since learned to appreciate that this help > me see the images better. This is also why I want the ratings to be a > toggle-able setting, because I only sometimes do I want to see them > everywhere. But when I do want to see them everywhere, I want them to be > easy to see. Nevertheless, I would be willing to compromise on the color, if > it means getting it into master :).
he. let's see. i think we can find something we can both live with :) > i know you can switch it off, but even with less obtrusive defaults i > will need a lot of convincing why it is a good idea to have it. > > > Because it helps me keep track of my progress. My workflow looks like this: > > - import film roll > - quickly go through all images by accepting or rejecting them (stars and > reject cross) > - process and tag the highest rated images first, then the rest (if I feel > like it...) i do about the same thing, but in the second sweep i filter by star rating (i'm using 0 stars to mark for deletion, 1 for meh, and 2 for the second pass). > For this process it really helps me to see how far I have come, what I rated > that image, etc. I probably don't want ALL the settings turned on at the > same time, that would really be chaos. right. that's why you want fine grained control over color labels etc. hm. the top bar also has a problem with overall screen size on netbooks, we can't put too much into that.. > also, as jcsogo said in irc, i'm not sure about the buttons. maybe a > `clutter level' option in the preferences would do. > > > I would be fine with settings in the preferences dialog, as long as there > are shortcuts that allow me to quickly enable/disable the toggles. I want > the toggle buttons strictly from a UI perspective, I think it is bad form to > have too many things that are only accessible through a keyboard shortcut. > On the other hand, if they are accessible through the preferences dialog > then maybe that is good enough. > > > did you benchmark that with `darktable -d perf -d lighttable'? i would > expect the color label query to slow it down somewhat on zoomed out > views. > > > I have not done a proper benchmark yet, but I have not noticed any > performance changes either. I have tried disabling and enabling everything > and could not really notice a difference. I will do a test with -d > lighttable later. > > I don't want to start a new discussion about performance in this thread, but > my idea for the future was to load all the details for all displayed images > in a single query and store them in a struct for later access. This ought to > improve performance - what do you think?. good idea. usually the idea was to put that in the dt_image_t structs and sync with db every time you do release a cached struct after acquiring a write lock on it. i guess that should work fine for color labels and such, but needs some changes in the rest of the code (every time you change a color label it would now have to go through the cache to make sure everything is consistent). is that about the infrastructure you were looking for? (yea, we could start a new thread i guess). -jo ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_jan _______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
