On Mon, Oct 28, 2013 at 4:13 PM, Moritz Moeller <virtualr...@gmail.com>wrote:
> On 28/10/13 3:49 PM, johannes hanika wrote:
> > Highlight reconstruction is still broken. This used to work (not
> > perfect, but work) before
> >
> > no, not true. it never reconstructed color, highlights were always
> > desaturated (well, you could add some magenta to it..)
>
> I'm not talking about color reconstruction in highlights, I'm just
> talking about it working at all. :]
>
> I.e. the last release does not have the stuff in the 'highlights' branch
> which works somehow (even w/o color). The code in 1.2.3 just seems to
> blow out everything.
> I suggest to either roll back what got broken in 1.2.3 or merge the
> 'highlights' branch into master b4 doing the next release.
>
houz is talking about 1.4 which will be based on git master. 1.2.3 belongs
to the `ancient' branch of dt.
the difference between the highlights branch and master in the respective
module is unrelated to image processing:
git diff master..highlights -- ../../src/iop/highlights.c
diff --git a/src/iop/highlights.c b/src/iop/highlights.c
index 5a52934..38864c7 100644
--- a/src/iop/highlights.c
+++ b/src/iop/highlights.c
@@ -374,7 +374,7 @@ void gui_init(struct dt_iop_module_t *self)
g->mode = dt_bauhaus_combobox_new(self);
gtk_box_pack_start(GTK_BOX(self->widget), g->mode, TRUE, TRUE, 0);
- dt_bauhaus_widget_set_label(g->mode, NULL, _("method"));
+ dt_bauhaus_widget_set_label(g->mode, _("method"));
dt_bauhaus_combobox_add(g->mode, _("clip highlights"));
dt_bauhaus_combobox_add(g->mode, _("reconstruct in LCh"));
g_object_set(G_OBJECT(g->mode), "tooltip-text", _("highlight
reconstruction method"), (char *)NULL);
@@ -382,7 +382,7 @@ void gui_init(struct dt_iop_module_t *self)
g->clip = dt_bauhaus_slider_new_with_range(self, 0.0, 2.0, 0.01,
p->clip, 3);
g_object_set(G_OBJECT(g->clip), "tooltip-text", _("manually adjust the
clipping threshold against"
" magenta highlights (you shouldn't ever need to touch
this)"), (char *)NULL);
- dt_bauhaus_widget_set_label(g->clip, NULL, _("clipping threshold"));
+ dt_bauhaus_widget_set_label(g->clip, _("clipping threshold"));
gtk_box_pack_start(GTK_BOX(self->widget), g->clip, TRUE, TRUE, 0);
>
> .mm
>
>
------------------------------------------------------------------------------
October Webinars: Code for Performance
Free Intel webinars can help you accelerate application performance.
Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from
the latest Intel processors and coprocessors. See abstracts and register >
http://pubads.g.doubleclick.net/gampad/clk?id=60135991&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
