Hallöchen! Pascal Obry writes:
> Looking at the lens.c evolution it seems that this loose search has > never been activated. > Don't know why, but it seems to be working just fine in my case. We > had many report about > lens mis-match on the mailing-list, is there good reasons to not > activate this loose search? > > If not, why not consider > https://github.com/darktable-org/darktable/pull/406 for inclusion into > 1.4? > > This patch seems quite safe on the dt side :) > > What do you think? Let me briefly explain what the search modes mean: 1. Normal search: Both model names (that in the database entry and that in the EXIF data) are split into "words", i.e. consecutive character sequences of one character class (letters, digits, punctuation). Single punctuation words are discarded, as is the single letter "f". Thus, "Nikon AF-S Zoom-Nikkor 24-70mm f/2.8G ED" becomes the array [nikon, af, s, zoom, nikkor, 24, 70, mm, 2, 8, g]. Then, both arrays are compared. Important: *All* EXIF words must be found in the database entry! 2. Loose search: Like normal search, but it is allowed that EXIF words are unavailable in the database entry. In both cases, the number of matched words is divided by the total number of words, resulting in a score. This means: Lensfun model names should be as verbose as possible for good matching in normal search mode. Often, they are not. Therefore, Lensfun's original author included the "loose search". I don't like the loose search in Lensfun. It is just too loose. Well, there was a significant bug in it that may have caused that trouble Darktable had with the loose search a couple of months ago. So maybe one could give it a second chance, but I don't like the idea. My approach is to make Lensfun's model names longer, and to optimise for exiv2 explicitly. This has already been done systematically for Nikkors. For example, the lens mentioned in the above pull request would be detected properly by SVN Lensfun. Tschö, Torsten. -- Torsten Bronger Jabber ID: torsten.bron...@jabber.rwth-aachen.de or http://bronger-jmp.appspot.com ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
