Ah yes! I did do invert, sorry, I forgot to list it...
Speaking of invert, I think I found a bug in the existing code for
invert. For incoming Bayer-mosaiced float data, it does:
*out = CLAMP(film_rgb[FC(j+roi_out->x, i+roi_out->y, filters)] -
*in/(float)0xffff, 0, 1.0f);
but it shouldn't be dividing by 0xffff (that's only for the integer
case). Not only that, but for this and the int path, this should be
j+roi_out->y and i+roi_out->x?
Though I don't think any of this would be visible, because of where
invert is in the module pipeline? Regardless, I did change this in the
xtrans2 branch.
Dan
On Tue, Feb 11, 2014, at 02:52 PM, Tobias Ellinghaus wrote:
> Am Dienstag, 11. Februar 2014, 14:26:02 schrieb Dan Torop:
>
> [...]
>
> > - all raw-dependent modules except cacorrect (that is, highlight,
> > temperature, hotpixels, and rawdenoise)
>
> What about invert?
>
> [...]
>
> Tobias
> ------------------------------------------------------------------------------
> Android apps run on BlackBerry 10
> Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
> Now with support for Jelly Bean, Bluetooth, Mapview and more.
> Get your Android app in front of a whole new audience. Start now.
> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
> _______________________________________________
> darktable-devel mailing list
> darktable-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/darktable-devel
> Email had 1 attachment:
> + signature.asc
> 1k (application/pgp-signature)
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
darktable-devel mailing list
darktable-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/darktable-devel
