Thank you! I'm happy to work on fixes for any particular (or overall) flaws...
When in doubt I ordered changes to make the diffs as small as possible, which generally puts the x-trans case first in conditionals -- though it's clearly not the code path most people would care about. This may be worth another look. There's some question about dealing with UI and configuration data for demosaic -- as there is a different set of demosaic methods and parameters for Bayer than x-trans sensors. Right now the GUI changes the demosaic choices available whenever gui_update() is called. And a demosaicing_method of 0 means PPG for Bayer sensors, but bilinear for x-trans sensors. Though this is better than mucking up existing data structures via adding an xtrans_demosaicing_method parameter? Also, this may break with tiling -- I realize I haven't checked that yet. Dan On Tue, Feb 11, 2014, at 03:21 PM, jeremy rosen wrote: > overall i'm impressed > > great work > > > On Tue, Feb 11, 2014 at 9:52 PM, Tobias Ellinghaus <h...@gmx.de> wrote: > >> Am Dienstag, 11. Februar 2014, 14:26:02 schrieb Dan Torop: >> >> [...] >> >> >> > - all raw-dependent modules except cacorrect (that is, highlight, >> > temperature, hotpixels, and rawdenoise) >> >> What about invert? >> >> [...] >> >> Tobias >> ------------------------------------------------------------------------------ >> Android apps run on BlackBerry 10 >> Introducing the new BlackBerry 10.2.1 Runtime for Android apps. >> Now with support for Jelly Bean, Bluetooth, Mapview and more. >> Get your Android app in front of a whole new audience. Start now. >> >> http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk >> _______________________________________________ >> darktable-devel mailing list >> >> darktable-devel@lists.sourceforge.net >> >> https://lists.sourceforge.net/lists/listinfo/darktable-devel >> > > ------------------------------------------------------------------------------ > Android apps run on BlackBerry 10 > Introducing the new BlackBerry 10.2.1 Runtime for Android apps. > Now with support for Jelly Bean, Bluetooth, Mapview and more. > Get your Android app in front of a whole new audience. Start now. > http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk > _________________________________________________ > darktable-devel mailing list > darktable-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/darktable-devel ------------------------------------------------------------------------------ Android apps run on BlackBerry 10 Introducing the new BlackBerry 10.2.1 Runtime for Android apps. Now with support for Jelly Bean, Bluetooth, Mapview and more. Get your Android app in front of a whole new audience. Start now. http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
