nice, thanks for looking into that x server issue. a couple of comments: this hunk looks like it doesn't change anything to me:
- disk_t *g = (disk_t *)self->gui_data; + disk_t *g = NULL; + // dirty hack to make the cli work + if (self->gui_data) + g = (disk_t *)self->gui_data; and your second patch includes both the first and the second commit? did you try git format-patch to create those patches? -jo On Wed, Apr 2, 2014 at 4:30 AM, Kevin <kmg...@bigpond.com> wrote: > Attached is a tar file containing two "git diff" files. They have been > generated > from two local branches each of which address issues with the cli facility. > > 1) cli_fix - This branch addresses the following issues: > * Bug 9473: http://darktable.org/redmine/issues/9473 > * Unreported bugs where the cli crashes if the value of the parameters > height, width, bpp or hq parameters is missing > > These changes are not as clean as they could be - see around line 158 in > the module imageio/storage/disk.c but it is the best I could think of. > > 2) cli_overwrite - This branch extends the cli_fix branch by adding a "-- > overwrite" option. The current version from the "master" branch renames the > output file, if necessary. If this option is specified, it is the same as > checking the corresponding checkbox in the GUI. > > Again this isn't as neat as it could be. This is due to the remapping > of a > dt_imageio_module_data_t struct to dt_imageio_disk_t! > > As this is my first hack at the darktable source, these changes will need a > good amount of testing. > > Cheers, > Kevin > > > ------------------------------------------------------------------------------ > > _______________________________________________ > darktable-devel mailing list > darktable-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/darktable-devel > >
------------------------------------------------------------------------------
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
