Am Mittwoch, 9. April 2014, 15:14:20 schrieb Kevin: > Attached is a patch that addresses Feature Request 9861 ( > http://darktable.org/redmine/issues/9861 ). > > In the "tool tip" the list of available pre-defined variables is in an order > other than alphabetical. Is this for a reason? Perhaps the most most useful > ones are at the top? Or did it just "grow" to it's present form? > > In case it is thought that the list should be in alphabetical order, I have > generated two version of the patch: > > 1) issue_9861_unsorted.patch - implements only the Feature Request; and > 2) issue_9861_sorted.patch - as above but also sorts the entries in the > "tool tip" list.
The change to common/variables.c has to call g_list_free_full(res, &g_free); to not leak memory. The sorting of the variables is not what we want, they were ordered in a logical way (year > month > day > hour > minute ...). Putting other variables inbetween makes that hard to read. Conclusion: I will push it with the freeing fixed. Thanks. Two more comments for future patches: - please discuss the changes with us in IRC first so you don't waste time as with the dt-cli patch. - please provide patches done with git format-patch so we can apply them with your name and commit message. I'll be doing that manually now, no worries, it's just to make sure to not forget attributing you. > Kevin Tobias
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
