On Thu, 10 Apr 2014 14:09:45 Tobias Ellinghaus wrote: > Am Mittwoch, 9. April 2014, 15:14:20 schrieb Kevin: > > Attached is a patch that addresses Feature Request 9861 ( > > http://darktable.org/redmine/issues/9861 ). > > > > In the "tool tip" the list of available pre-defined variables is in an > > order other than alphabetical. Is this for a reason? Perhaps the most > > most useful ones are at the top? Or did it just "grow" to it's present > > form? > > > > In case it is thought that the list should be in alphabetical order, I > > have > > generated two version of the patch: > > > > 1) issue_9861_unsorted.patch - implements only the Feature Request; and > > 2) issue_9861_sorted.patch - as above but also sorts the entries in the > > "tool tip" list. > > The change to common/variables.c has to call > g_list_free_full(res, &g_free); > to not leak memory.
Yes, that had occurred to me when I was away from the computer - and that was the last I thought of it. :( > > The sorting of the variables is not what we want, they were ordered in a > logical way (year > month > day > hour > minute ...). Putting other > variables inbetween makes that hard to read. OK, thought there may have been a reason for the current order - hence the two versions of the patch. Time wasted: << 5 mins. > > Conclusion: I will push it with the freeing fixed. Thanks. > > Two more comments for future patches: > - please discuss the changes with us in IRC first so you don't waste time as > with the dt-cli patch. IRC is not an option - I'm on the east coast of Australia. Re dt-cli patch: at the very least, one of my original two patches should be applied as they address the core issue of the cli not running in a non-gui environment. > - please provide patches done with git format-patch so we can apply them > with your name and commit message. Will do, if I can get it to work - but attribution is irrelevant to me. > I'll be doing that manually now, no > worries, it's just to make sure to not forget attributing you. > > > Kevin > > Tobias Kevin ------------------------------------------------------------------------------ Put Bad Developers to Shame Dominate Development with Jenkins Continuous Integration Continuously Automate Build, Test & Deployment Start a new project now. Try Jenkins in the cloud. http://p.sf.net/sfu/13600_Cloudbees _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
