Hi Gert, yes it is supposed to remove LCA, but in the end it also worked for people removing light TCA (of course it wasn't specifically made to do that and shouldn't be optimized for that).
The issues are still: - processing speed (but maybe okay, opencl code still needs to be written as soon as it works good enough) - accidentally desaturating the wrong parts - artifacts in some cases with "global average" (just have seen that now that i rebased on the current master, maybe these were hidden before, need to check the code again) - too much controls/sliders I just did a rebase on the current master and changed the controls again a bit. See here again: https://github.com/bluesceada/darktable/tree/defringe Maybe also interesting, see my original (first) mail from months ago: http://sourceforge.net/p/darktable/mailman/message/31538991/ (there are some follow ups) Best regards, Dennis On 15.04.2014 23:29, Gert van der Plas - Schrama wrote: > Thanks for the response. Do you mean with defringing, removing purple > edges and longitudinal ca? > > Op 15 apr. 2014 10:58 schreef "Dennis Gnad" <den...@xorn.org > <mailto:den...@xorn.org>>: > > On 15.04.2014 10:32, Gert van der Plas - Schrama wrote: > > And it would be really awesome if the ca correction could correct for > > dispersion caused bij fishtanks or underwater cases ;-) > > I would guess something like fishtanks (I guess you mean just > photographing into a fishtank from the outside?) might be too chaotic, > and maybe better handled by a phenomenological correction that detects > "fringing" edges (by detecting highly saturated edges). I worked on that > before ("defringe" module), but currently can't find time to finish it, > (or rather improve it the way I would like it to be). The code is > currently there but should be rebased on current master before (wow it > was already 6 months ago :-/ ): > > https://github.com/bluesceada/darktable/tree/defringe > > I will rebase it on current master during the next days. > > Best regards, > Dennis > ------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
