Hello Stéphane, I tried your improvements and cloned your repo, merged cacorrect to master and compiled. But It seems that it is not working properly, the module looks like this: https://sebix.at/tmp/cacorrect.png It's just empty and I have no sliders or anything else.
I also get some weird output on the console, I don't know where it comes from: $ /opt/darktable/bin/darktable error: T error: R error: U error: E I'll send you a private link to the image I used. Thanks and regards, Sebastian On 2014-04-10 17:03, Stéphane Gimenez wrote: > Hi there, > > I've (vastly) improved the color aberration auto-correction algorithm. > Color correction is now almost perfect (precise roughly to the 10th of > pixel) for all the pictures it tested it on. But the new code needs > more testing, especially on pictures from other cameras. > > You can get it here: > git pull https://github.com/sgimenez/darktable.git cacorrect > > And here's the first commit: > > https://github.com/sgimenez/darktable/commit/e201b2250bfa1eb033f3c1497779396e37e237bd > > If you give me some help for testing, I'll try to further improve > performance and initiate a pull request. > > Cheers, > Stéphane > > Notes: > > 1. Currently, the correction is only applied on export. > Use the following to activate it in the GUI: > plugins/darkroom/cacorrect/display=1 > > 2. Visual hints of the applied corrections may be produced. A red (or > respectively blue) is shown where the applied color shift has a norm > close to 0.0, 0.5, 1.0, 1.5, etc. (in pixels). Green dots mark the > weight of the surrounding area that was used for color shift > calculations. Activate those indicators with: > plugins/darkroom/cacorrect/visuals=1 > > 3. The legacy algorithm is still available for comparison purposes with: > plugins/darkroom/cacorrect/legacy=1 > > > > > ------------------------------------------------------------------------------ > Learn Graph Databases - Download FREE O'Reilly Book > "Graph Databases" is the definitive new guide to graph databases and their > applications. Written by three acclaimed leaders in the field, > this first edition is now available. Download your free book today! > http://p.sf.net/sfu/NeoTech > _______________________________________________ > darktable-devel mailing list > darktable-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/darktable-devel
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Learn Graph Databases - Download FREE O'Reilly Book "Graph Databases" is the definitive new guide to graph databases and their applications. Written by three acclaimed leaders in the field, this first edition is now available. Download your free book today! http://p.sf.net/sfu/NeoTech
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
