Hi, I did some further checks on older images.
Frankly speaking, I have to say we are in a deep shit. Just checked an image where some weeks ago I successfully applied geometric lens correction. Nothing works now, image is heavily distorted. Can't even get darktable to detect the lens profile. Many other issues like wrong white balances. My impression: we either shift 1.6 by at least 2 months until everything is sorted out, or we urgently need to revert the latest commits to bring us back to a working state :( Ulrich Am 23.10.2014 um 09:53 schrieb johannes hanika: > cool, thanks for checking. > > the problem seems to be pr 699 and afterwoes.. the core problem is a > race condition on dt_image_t data in the pipeline: some more recent and > more complicated raw tricks (some specific to esoteric sensors, some > just about black/white levels) require rawspeed to load some metadata > before the pipeline inits itself in reload_defaults or commit_params. > this isn't always guaranteed, as the raw is loaded on demand in the > thread for the full pipeline, and reload_defaults is a gui thread callback. > > in fixing this (we now load the bloody raw first thing when entering > darkroom mode, in the gui thread :( we could just load the metadata if > there was support for this in rawspeed), we discovered that > reload_defaults is called quite a few times, redundantly. but cleaning > that up seems to be not just a matter of not calling it, but also > teaching individual modules to work well with the calling order gui_init > - reload_defaults - gui_update. especially colorin.c seems to have > problems with that. > > now in master is the fix for the race condition, and nothing related to > reload_defaults cleanup work. this means it's being called a ton of > unnecessary times, and i have no confidence in the calling order for > multi-instance modules. but this is the same situation as it was before, > so that should be stupid from a dev point of view but not dangerous from > a user's perspective. > > cheers, > jo > > > ------------------------------------------------------------------------------ _______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
