hi all. could you two tell me how to reproduce the lens correction/crash issues? i pretty much reverted everything reload_defaults related already. the only thing that should be in master (and could stay imho, don't see how it would cause problems) is the blocking loading of the full buffer via rawspeed to init all the dt_image_t special data.
i'll carefully review all related patches and the net diff and see if there is a broken line that slipped, and revert that too. and yes. in the long term i vote for a rewrite of some parts here: - module instance initialisation is messy and different to regular modules - maybe we don't need the preview pipeline any more if raw loading is as fast as it is? - reload_defaults is funny. we should carefully rethink that and maybe opt for another interface (like: separate gui and core in modules in a way that they can live on their own, so we can just call module_core->init() and leave module_gui->init() as it was when switching images?) cheers, jo On Thu, Oct 23, 2014 at 10:33 PM, Pedro Côrte-Real <pe...@pedrocr.net> wrote: > On Thu, Oct 23, 2014 at 9:15 PM, Ulrich Pegelow > <ulrich.pege...@tongareva.de> wrote: > > My impression: we either shift 1.6 by at least 2 months until everything > > is sorted out, or we urgently need to revert the latest commits to bring > > us back to a working state :( > > Yeah, unless hanatos has an idea on how to fix things we should > probably revert. The code seems to be extremely brittle. Current > master is crashing for me. > > We probably need to forget about this for 1.6 and just plan a partial > rewrite of this right after. > > Pedro >
------------------------------------------------------------------------------
_______________________________________________ darktable-devel mailing list darktable-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/darktable-devel
