yes, that's definitely not the right fix since it leaves a memleak behind... however this is probably the best workaround until I find a correct fix. you might also want to comment the line just above, to be safe...
properly fixing that one is very tricky. i'm looking into it, stay tuned... as for your other questions: 1) just comment the "check_version" line for the time being, it's here to check compatibility between DT version, you don't really need it during developement Q1) that's not how prefs work. dt.preferences.register creates an new entry in the UI, the last value of the call (jpg_dir in your case) is the default value. i.e the value that will be set when you double-click the label next to the preference entry to get the value of a preference you need to call dt.preferences.read(<script>,<name>,<type>) and use the return value Q2) that's how storages work : they create temporary exports in a directory then they use them to create the final product. if you don't do that, how do you know that there is an existing jpg to use ? if you want to do that, registering a storage is not the right way to do that, but I am not sure what you are trying to do here... hope this helps... On Thu, May 28, 2015 at 7:40 AM, Pascal Obry <[email protected]> wrote: > Le jeudi 28 mai 2015 à 07:17 +0200, Matthias Bodenbinder a écrit : > > Hello Jeremy, > > > > I tested your script with newest git master. Here is what I found: > > > > 1) Version check line #31 is not working > > LUA ERROR : /home/matthias/.config/darktable-1.7//luarc:31: bad argument > #1 to 'check_version' (string expected, got nil) > > stack traceback: > > [C]: in function 'check_version' > > /home/matthias/.config/darktable-1.7//luarc:31: in main chunk > > > > 2) The frequent crashes are just too much to test it. It crashes most of > the time!! > > *** Error in `/opt/darktable-git/bin/darktable': double free or > corruption (out): 0x0000000002ab0260 *** > > /home/matthias/bin/darktable-git-starter.sh: line 3: 19762 Aborted > /opt/darktable-git/bin/darktable --configdir > /home/matthias/.config/darktable-1.7/ $* > > Same thing here, I have found that the crash is fixed with the following > patch. > > diff --git a/src/lua/luastorage.c b/src/lua/luastorage.c > index 21c281e..f7e9479 100644 > --- a/src/lua/luastorage.c > +++ b/src/lua/luastorage.c > @@ -270,7 +270,7 @@ static int32_t free_param_wrapper_job(dt_job_t *job) > free_param_wrapper_data *params = dt_control_job_get_params(job); > lua_storage_t *d = params->data; > g_list_free(d->imgids); > - g_list_free_full(d->file_names, free); > + // g_list_free_full(d->file_names, free); > if(d->data_created) > { > dt_lua_lock(); > > But this is probably not the right fix. I'll let our Lua expert look at > this issue. > > -- > Pascal Obry / Magny Les Hameaux (78) > > The best way to travel is by means of imagination > > http://v2p.fr.eu.org > http://www.obry.net > > gpg --keyserver keys.gnupg.net --recv-key F949BD3B > > > > ------------------------------------------------------------------------------ > _______________________________________________ > darktable-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/darktable-devel >
------------------------------------------------------------------------------
_______________________________________________ darktable-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-devel
