Stefan Klinger (2020-Jan-19, excerpt):
> or there might be a sign error in “filmic” (that nobody has
> noticed?!).
Now this "change" (I'm not claiming it to be a "fix"), would give me
bahaviour I personally would expect: In `src/iop/filmicrgb.c` change
p->black_point_source = p->black_point_source - grey_var;
to
p->black_point_source = p->black_point_source + grey_var;
It pretty much lets white and black at where I've set them and only
changes grey. But hey, I've just changed a sign in the middle of a
formula I don't understand....
Two more things:
Under “look”, when I move the “shadows/highlights balance” to the
right, the linear area in the diagram moves right. Could someone
please flip this?
I think it would be nice if the sliders for white, black, and grey
under “display” would be in the same order as under “scene”, so it'd
be easier to see where your values get mapped.
Cheers,
Stefan
--
Dr. Stefan Klinger -- Informatiker, Mathematiker o/X
https://stefan-klinger.de /\/
I prefer receiving plain text messages, not exceeding 32kB. \
____________________________________________________________________________
darktable user mailing list
to unsubscribe send a mail to [email protected]
