Hi Ulrich, how to use this in real world? In which module?
Mauro from Android
Gpg public key: 0x73E5AEA3
Il 25/gen/2014 17:44 "Ulrich Pegelow" <[email protected]> ha scritto:
> There have been reports on color problems which occur with certain camera
> models especially when an image shows highly saturated light sources like
> in stage photography. A typical symptom are black pixels or areas in the
> image if modules like levels or monochrome are activated. Issue #9479 gives
> a good example.
>
> The technical cause lies in the color transfer from camera RGB to Lab
> which under special circumstances may result in unbound values, e.g. pixels
> with negative L values. Most of our modules deal properly with unbound Lab
> but some don't have any chance to give a reasonable output - hence the
> black pixels.
>
> This pull request adds an option to the colorin module which on activation
> confines the Lab output of that module to some user selectable gamut. One
> can choose "sRGB" and "linear RGB" for a more restricted color space or
> "Adobe RGB" and "Beta RGB" for a broader gamut. You need to test what fits
> best to avoid artifacts and at the same time leave colors as un-damped as
> possible.
>
> It is important to mention that this gamut clipping option is not
> restricting modules further down the pixelpipe to produce Lab values
> outside of the chosen gamut. Therefore the selected color space is not to
> be mistaken as a "working color space".
>
> Would be great some of the other devs could review before merging.
> ------------------------------
> You can merge this Pull Request by running
>
> git pull https://github.com/upegelow/darktable normalize
>
> Or view, comment on, or merge it at:
>
> https://github.com/darktable-org/darktable/pull/443
> Commit Summary
>
> - gradientsliders: use NAN as value to disable display of color picker
> value
> - colorin: add option to normalize Lab values to real, ie. non-virtual
> colors
> - colorin: extended version: fix shortcomings; enable selection of
> clipping profiles; implement SSE and OpenCL codepaths
> - colorin: some code cleanup
>
> File Changes
>
> - *M*
> data/kernels/basic.cl<https://github.com/darktable-org/darktable/pull/443/files#diff-0>(70)
> - *M*
> src/common/colorspaces.c<https://github.com/darktable-org/darktable/pull/443/files#diff-1>(60)
> - *M*
> src/common/colorspaces.h<https://github.com/darktable-org/darktable/pull/443/files#diff-2>(3)
> - *M*
> src/develop/blend_gui.c<https://github.com/darktable-org/darktable/pull/443/files#diff-3>(4)
> - *M*
> src/dtgtk/gradientslider.c<https://github.com/darktable-org/darktable/pull/443/files#diff-4>(13)
> - *M*
> src/iop/colorin.c<https://github.com/darktable-org/darktable/pull/443/files#diff-5>(324)
> - *M*
> src/iop/colorin.h<https://github.com/darktable-org/darktable/pull/443/files#diff-6>(36)
> - *M*
> src/iop/relight.c<https://github.com/darktable-org/darktable/pull/443/files#diff-7>(2)
>
> Patch Links:
>
> - https://github.com/darktable-org/darktable/pull/443.patch
> - https://github.com/darktable-org/darktable/pull/443.diff
>
> --
> Reply to this email directly or view it on
> GitHub<https://github.com/darktable-org/darktable/pull/443>
> .
>
------------------------------------------------------------------------------
WatchGuard Dimension instantly turns raw network data into actionable
security intelligence. It gives you real-time visual feedback on key
security issues and trends. Skip the complicated setup - simply import
a virtual appliance and go from zero to informed in seconds.
http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk
_______________________________________________
Darktable-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-users
