Hello,

This is with darktable 1.4.1 and lensfun 0.2.7.

The Nikon D60 widely sold with the a specific lens. Here is the tag in 
exiftool:

Lens ID                         : AF-S DX VR Zoom-Nikkor 18-55mm f/3.5-5.6G

Expected: darktable lens correction module matches it with parameters in 
the database.

Observed: darktable lens correction module does not match it with 
parameters in the database. User has to choose manually this one (text 
pasted from /usr/share/lensfun/slr-nikon.xml):

         <model>Nikkor 18-55mm f/3.5-5.6G AF-S DX VR</model>

As you can see the information in the ID is not ordered the same in both 
texts.

Most of the 55 Nikkor lenses in darktable database are formatted like 
the example above : Nikkor then focal length in mm then aperture (f 
number) then keywords.

Plus one is like this just prefixed by Nikon before Nikkor, the "Nikon 
Nikkor 35mm f/1.8G AF-S DX".

The database has two lenses formatted similarly to my lens : Nikon then 
keywords then Nikkor then focal length in mm then aperture (f number) 
then possibly some more keywords.

         <model>Nikon AF-S DX VR Zoom-Nikkor 18-105mm f/3.5-5.6G ED</model>
         <model>Nikon AF Nikkor 50mm f/1.8D</model>

What should we do to the lensfun database so that at least the common 
lens that I use is recognized ?

* Change the name ? That would break darktable for the lenses that use 
the other ordering, if they exist (they probably exist, don't they ?)
* Duplicate the declaration ? That would work but is inelegant.
* Declare several names for the same lens ? Does lensfun allow that ?
* Change lensfun matching algorithm so that it recognizes both ? That 
sounds complicated.

Please hint.

Thank you for your attention.

-- 
Stéphane Gourichon


------------------------------------------------------------------------------
_______________________________________________
Darktable-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-users

Reply via email to