Am Donnerstag, 22. Mai 2014, 19:40:18 schrieb Stéphane Gourichon: > Hello,
Hi.
[...]
> apt-get install --no-install-recommends intltool libatk1.0-dev
> libcairo2-dev libsoup2.4-dev libexiv2-dev libfontconfig1-dev
> libfreetype6-dev libgomp1 libgtk2.0-dev libjpeg-dev libtiff4-dev
> liblcms2-dev liblensfun-dev libpng12-dev libsqlite3-dev
> libstdc++6-4.4-dev libxml2-dev libopenexr-dev libcurl4-gnutls-dev
> libgphoto2-2-dev libdbus-glib-1-dev libgnome-keyring-dev fop
> librsvg2-dev libflickcurl-dev cmake liblua5.2-dev
This could be replaced with "apt-get build-dep darktable".
[...]
> # Without libcolord-dev, build fails
>
> cmake does not complain about libcolord-dev yet build fails with:
>
> darktable/src/external/colord-gtk/src/colord-gtk/cd-window.c:39:20:
> fatal error: colord.h: Aucun fichier ou dossier de ce type
Please paste English messages only, I have no idea what that is supposed to
mean.
> #include <colord.h>
> ^
> compilation terminated.
>
>
>
> # With libcolord-dev, build succeeds
>
> apt-get install libcolord-dev
>
> And it builds.
This is a little strange. When colord-dev is missing the corresponding code
shouldn't be build at all.
> # Looking at CMakeList
>
> In ./src/CMakeLists.txt I read :
>
>
> # we ship our own copy of libcolord-gtk - the one packaged in
> distros is linked against gtk3 :(
> include_directories(${CMAKE_CURRENT_SOURCE_DIR}/external/colord-gtk/src)
> add_library(colord-gtk_static STATIC IMPORTED)
>
>
> but see no "external" subdirectory (at least in master branch)
>
> Trying to see if it is in some branches :
>
> git log --all -- external
It's src/external/. Not that hard to find, is it?
> So it looks like CMakeList.txt is written with the idea of shipping a
> copy of libcolord, so it's normal not to complain if the system has
No, we are shipping libcolord-gtk and not libcolord.
> none, but there's actually no copy of libcolord and build fails.
>
> # What to do ?
>
> * mention libcolord-dev among the dependencies (fix builds), clean up
> CMakeList.txt ?
It shouldn't be a dependency, just an extra feature that may be missing. And
for me that works fine. How are you compiling, and what is the output from
cmake with a clean build/ directory?
> * ship libcolord ?
No.
> Thank you for your attention.
Tobias
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs
_______________________________________________ Darktable-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/darktable-users
