Hello,

# Context

On Ubuntu 14.04 (actually Xubuntu), following 
http://www.darktable.org/install/ I did:

git pull

Today it brings :

commit 8daa088a172c48c46a5ce89b3b2488ff54b25216
Author: Pascal de Bruijn <[email protected]>
Date:   Thu May 22 18:25:14 2014 +0200

     rawspeed: Canon PowerShot S120 support

Then:

apt-get install --no-install-recommends intltool libatk1.0-dev 
libcairo2-dev libsoup2.4-dev libexiv2-dev libfontconfig1-dev 
libfreetype6-dev libgomp1 libgtk2.0-dev libjpeg-dev libtiff4-dev 
liblcms2-dev liblensfun-dev libpng12-dev libsqlite3-dev 
libstdc++6-4.4-dev libxml2-dev libopenexr-dev libcurl4-gnutls-dev 
libgphoto2-2-dev libdbus-glib-1-dev libgnome-keyring-dev fop 
librsvg2-dev libflickcurl-dev cmake liblua5.2-dev

(Notice the no-install-recommends which avoids some overweight and 
sometimes shows dependencies that were forgotten and this implicit, 
which may be the case here.)

That was not enough to build DarkTable.



# Without libcolord-dev, build fails

cmake does not complain about libcolord-dev yet build fails with:

darktable/src/external/colord-gtk/src/colord-gtk/cd-window.c:39:20: 
fatal error: colord.h: Aucun fichier ou dossier de ce type
  #include <colord.h>
                     ^
compilation terminated.



# With libcolord-dev, build succeeds

apt-get install libcolord-dev

And it builds.



# Looking at CMakeList

In ./src/CMakeLists.txt  I read :


     # we ship our own copy of libcolord-gtk - the one packaged in 
distros is linked against gtk3 :(
include_directories(${CMAKE_CURRENT_SOURCE_DIR}/external/colord-gtk/src)
     add_library(colord-gtk_static STATIC IMPORTED)


but see no "external" subdirectory (at least in master branch)

Trying to see if it is in some branches :

git log --all -- external


So it looks like CMakeList.txt is written with the idea of shipping a 
copy of libcolord, so it's normal not to complain if the system has 
none, but there's actually no copy of libcolord and build fails.

# What to do ?

* mention libcolord-dev among the dependencies (fix builds), clean up 
CMakeList.txt ?
* ship libcolord ?



Thank you for your attention.

-- 
Stéphane Gourichon


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Darktable-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/darktable-users

Reply via email to