On Wed, Oct 06, 2010 at 05:04:20AM -0500, Jonathan Nieder wrote:
>
> Herbert Xu wrote:
> 
> > This is wrong.  You're creating exactly the problem that Jilles
> > was talking about where dot(1) is returning 127.  This code should
> > be moved to procargs, which runs only for the "sh script" case.
> 
> Makes sense.  How does this look?
> 
> It still ignores attempts to run "sh directory"; see the next
> patch for that.

Actually I was wrong.  I had misunderstood Jilles' report and
thought that the problem is with 127 coming from dotcmd.  His
problem is actually with dotcmd bailing out which your (or was
it Gerrit's?) EXFILE patch already addressed.

However, instead of adding an ad-hoc exception for EXFILE, I'm
simply going to move the exit status setting for EXERROR out of
main.c and into error.c which should let you get what you want.

Cheers,
-- 
Email: Herbert Xu <herb...@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe dash" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to