It's done! http://github.com/ognen/do/tree/master
I cloned from http://github.com/sam/do/tree/master and sent sam a pull request. Was not able to find you on Github. Is this ok? Ognen On Jan 23, 11:21 am, Ognen Ivanovski <[email protected]> wrote: > Great! > > Will do this over the weekend and put the patch on LH. > > Ognen > > On Jan 23, 8:20 am, Dirkjan Bussink <[email protected]> wrote: > > > On 23 Jan 2009, at 02:00, Ognen Ivanovski wrote: > > > > - do you know a way how top postpone checking if sqlite3_open_v2() > > > is available from compile time to runtime? Or should i resort to > > > #ifdefs? > > > Easiest is probably do let extconf.rb do the checking and use #ifdefs > > based on that. The issue here is though that the signature of > > sqlite3_open and sqlite3_open_v2 differ, so they can't be simply > > interchanged (like in the case of sqlite3_prepare / sqlite3_prepare_v2 > > that you might have seen). > > > You can't defer this check to runtime, it has to be done compile time > > because the library needs to be linked. As long as it's properly > > backwards compatible I'm ok with the change. I do think we should use > > sqlite3_open_v2 always for >= 3.5.0, so not only when certain options > > are requested. > > > Submitting a batch can easily be done with git format-patch and > > putting it on LH, or by sending me a pull request through github. > > > -- > > Regards, > > > Dirkjan Bussink --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "DataMapper" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/datamapper?hl=en -~----------~----~----~----~------~----~------~--~---
