Trilok, Thanks for the review. After working on the review comments, will submit this patch to the net-dev list too.
Regards, Chaithrika ________________________________________ From: Trilok Soni [EMAIL PROTECTED] Sent: Wednesday, December 03, 2008 11:27 PM To: Subrahmanya, Chaithrika Cc: [email protected] Subject: Re: [PATCH 3/8] ARM: DaVinci: EMAC: ET1011C PHY driver Hi Chaithrika, On Wed, Dec 3, 2008 at 5:56 PM, <[EMAIL PROTECTED]> wrote: > From: Chaithrika U S <[EMAIL PROTECTED]> > > Adds ET1011C Phy driver. This driver is used by DM646x. This driver too should come from mainline, so you need to submit this driver to LKML and net-dev mailing list. > + > +#define ET1011C_STATUS_REG (26) > +#define ET1011C_CONFIG_REG (22) If this register off then please convert them to hex values. > + > +int et1011c_config_aneg(struct phy_device *phydev) > +{ This should be static. -- ---Trilok Soni http://triloksoni.wordpress.com http://www.linkedin.com/in/triloksoni_______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
