Hello.
Subbrathnam, Swaminathan wrote:
-----Original Message-----
From: Sergei Shtylyov [mailto:[EMAIL PROTECTED]
Sent: Thursday, December 04, 2008 11:02 PM
To: Subbrathnam, Swaminathan
Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; davinci-linux-open-
[EMAIL PROTECTED]
Subject: Re: [PATCH 3/3] MUSB : Fix for STALL handling in musb gadget code
Subbrathnam, Swaminathan wrote:
If EP is busy, we have even less reason to do a giveback. This is
not a
real fix, just pallialtive. Actually, whether a STALL token has been
sent or
not shouldn't play any role in giving back URB, so the fragment being
pacthed
is just totally wrong. Other drivers just don't allow EP that is still
active
to be halted, and this driver should do the same.
Your comment is plain wrong. I think there are scenarios that would
require requests to be given back during stall handling. I am laying one
out below for
4. On completion of the STALL (on SENTSTALL interrupt) driver would
need to abort the current transfer and return the USB request with
appropriate status. Here the EP state is busy handling the in-flight IO
and the request that is active has to be returned/givenback.
Don't know how I missed this hilarity. This passage made me wonder
whether
you've really taken time to look when ep->busy gets set. Do it please,
you'll
be surprised. :-)
<SWAMI> Pl. refer to the patch that I submitted yesterday. This patch is exactly for fixing the "hilarity" that you talk about.
Can you tell us why you're posting your patches in reverse order? To
waste everybody's valuable time?
Hope you had a good time with the "hilarity" !!!! Unfortunate that I had to cut
it short.
I need to look at that patch yet...
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
