Hello.
Gupta, Ajay Kumar wrote:
>>>> Fixes the SENTSTALL handling code to look for EP busy status before
>>>> returning the request. If EP is not busy do not giveback the request and
>>>> restart the request in the context of CLEAR STALL feature from the
>>>> host.
>> Eacactly this restaring thing is *wrong*.
>> For example, the USB storage driver on the host side will expect CSW
>> to be received after STALL, but your code will continue to send data if
>> it had a data transfer still in progress at the time when the endpopint
>> was halted.
> No, it wouldn't. The in-progress usb_request will be aborted and given back
> in SENTSTALL interrupt routine.
No, it won't be. Check the current code and Swaminathan's initial patch in
its context.
> The busy flag prevents the CSW request (if submitted)
> to be given-back accidentally.
Not, it doesn't as the current code woun't set it when this patch expects
it to (while processing a request).
> Now when the HOST sends the CLEAR_FEATURE for halted
> endpoint then the CSW request will be programmed for IO.
*Please* check the current MUSB upstream code before replying.
Swaminathan's intial patch won't work as expected not being supported by the
patch that changed ep->busy behavior.
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
