Troy,

> -----Original Message-----
> From: [EMAIL PROTECTED]
> [mailto:[EMAIL PROTECTED] On Behalf
> Of Troy Kisky
> Sent: Saturday, December 06, 2008 1:42 AM
> To: [email protected]
> Subject: [PATCH 11/14] ARM: DaVinci: dma: clear link on stop
> 
> Do what the comment says and actually clear the link.
> 
> Signed-off-by: Troy Kisky <[EMAIL PROTECTED]>
> 
> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c
> index 8322743..767d4e8 100644
> --- a/arch/arm/mach-davinci/dma.c
> +++ b/arch/arm/mach-davinci/dma.c
> @@ -1241,6 +1241,7 @@ void davinci_stop_dma(int lch)
>                * then just set the link field of the corresponding
>                * param entry to 0xffff
>                */

I feel this comment had to be removed in first place.

> +             ptr_edmacc_regs->paramentry[lch].link_bcntrld |= 0xffff;

I know that you added the above line of code to complement the comment but this 
change is breaking audio on DM644x. With this change, aplay/arecord returns 
Input/Output error.

Regards, Sudhakar

>       } else if (DAVINCI_EDMA_IS_Q(lch)) {
>               /* for QDMA channels */
>               ptr_edmacc_regs->qeecr = (1 << (lch - DAVINCI_EDMA_QSTART));
> --
> 1.5.4.3
> 
> 
> _______________________________________________
> Davinci-linux-open-source mailing list
> [email protected]
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to