Troy, > -----Original Message----- > From: Troy Kisky [mailto:[EMAIL PROTECTED] > Sent: Wednesday, December 10, 2008 3:27 AM > To: Rajashekhara, Sudhakar > Cc: [email protected] > Subject: Re: [PATCH 11/14] ARM: DaVinci: dma: clear link on stop > > Rajashekhara, Sudhakar wrote: > > Troy, > > > >> -----Original Message----- > >> From: [EMAIL PROTECTED] > >> [mailto:[EMAIL PROTECTED] On > Behalf > >> Of Troy Kisky > >> Sent: Saturday, December 06, 2008 1:42 AM > >> To: [email protected] > >> Subject: [PATCH 11/14] ARM: DaVinci: dma: clear link on stop > >> > >> Do what the comment says and actually clear the link. > >> > >> Signed-off-by: Troy Kisky <[EMAIL PROTECTED]> > >> > >> diff --git a/arch/arm/mach-davinci/dma.c b/arch/arm/mach-davinci/dma.c > >> index 8322743..767d4e8 100644 > >> --- a/arch/arm/mach-davinci/dma.c > >> +++ b/arch/arm/mach-davinci/dma.c > >> @@ -1241,6 +1241,7 @@ void davinci_stop_dma(int lch) > >> * then just set the link field of the corresponding > >> * param entry to 0xffff > >> */ > > > > I feel this comment had to be removed in first place. > > > >> + ptr_edmacc_regs->paramentry[lch].link_bcntrld |= 0xffff; > > > > I know that you added the above line of code to complement the comment > but this change is breaking audio on DM644x. With this change, > aplay/arecord returns Input/Output error. > > > > Regards, Sudhakar > > It doesn't break my audio (also dm644x.) I think that your audio driver > should be fixed (which my later RFC patch > tries to do.) But if it's causing you problems, it should go in after the > audio driver fix.
I have built audio statically and output of proc/version says "Linux version 2.6.28-rc6-davinci1". I am using MontaVista 4.2.0-3. 0.0.0702771 2007-03-10 toolchain. When I execute aplay I get the following error: # aplay test Playing WAVE 'test' : Signed 16 bit Little Endian, Rate 44100 Hz, Stereo aplay: pcm_write:1264: write error: Input/output error # As you know your RFC patch is also not working. I made the change which you had suggested in tlvaic3x.c file but the behavior is same. The other EDMA related patches have no issues. After applying all the EDMA patches, if I just comment out the line added by the patch No.11, the above error goes away and audio works fine. Regards, Sudhakar > > > Thanks for testing. Do the rest of the patches cause you any problems? > > Thanks > Troy > > _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
