Hello.
David Brownell wrote:
The driver prevents using the same numbered Rx/Tx endpoints simultaneously for
the periodic transfers -- which would actually be correct unless they share the
same FIFO. Use 'in_qh' and 'out_qh' fields of the 'struct musb_hw_ep' to check
the endpoint's business and get rid of now completely useless 'periodic' array
in the 'struct musb'. While at it, optimize the loop induction variable in the
endpoint lookup code and remove duplicate/unneeded code elsewhere...
Signed-off-by: Sergei Shtylyov <[email protected]>
Your patch comments need improvement. This would better be
titled "rewrite endpoint allocation", and the description
should highlight "make better use of resources".
No, the previous scheme was just based on the wrong assumption.
Not using something that's available is sub-optimal, but rarely a bug.
Well, the patch that this one replaced was classified a s a fix and
was in Greg's usb.current/ for some time (until I requested its removal
due to its brokennes). This is only a replacement, so you should've
really spoken up several months earlier. ;-)
This doesn't seem to fix anything hurtful; so, it's not
for 2.6.29 merge.
What I'm going to do is send a replacement with a better
description and my signoff.
I can only be happy if someone writes the patch description for me. :-)
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
