On Thursday 12 February 2009, Sergei Shtylyov wrote: > > I can only be happy if someone writes the patch description for me. :-) > > In fact, after having seen your changes, I'm not at all happy and have > to ask you to stop editing my patches and just point for what you think > needs to be improved.
Then when you write patch descriptions, put a lot more effort into having them convey all the *important* info, and not require more time to read and understand than the actual patch. Be succinct; prioritize. Bigger is not better. Several of those descriptions were actual obstacles to the patch review. That one run-on sentence sticks in my mind. It was less than six lines only because your lines were so very long ... clearly needed reformatting, and for more reasons than the four spaces "git log" adds at the beginning of each line. _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
