On Tue, Mar 10, 2009 at 12:18:31AM +0300, Sergei Shtylyov wrote:
> Hello.
>
> Mark A. Greer wrote:
>
>> The base address for the DMA's Third Party Channel Controller is currently
>> hardcoded. Instead, use the base address that is already in the resource
>> data for the controller.
>>
>> Signed-off-by: Mark A. Greer <[email protected]>
>> + edmacc_regs_base = ioremap(r->start, len);
>> + if (!edmacc_regs_base) {
>> + status = -EBUSY;
>>
>
> Not ENOMEM? That's quite minor tho...
I thought about ENOMEM but, in theory, it is possible that it would work
if you tried it again if some virtual mem space freed up, for example.
>> + goto fail1;
>>
>
> Not very telling label...
No matter what I labelled it, the reader has to scroll back to see
what really happened.
Mark
--
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
