On Friday 13 March 2009 22:37:36 Karicheri, Muralidharan wrote:
>
> Hello Everyone,
>
> I have just submitted VPFE capture driver for review. As you might now, the
> V4L2 community has come up with a v4l2 sub device model for integrating v4l2
> bridge driver to decoder drivers. But the TVP514x decoder driver available in
> open source kernel tree is using another model called v4l2-int-device. So I
> had to port the driver using v4l2-int-device model. The plan is to migrate to
> v4l2 sub device model once TVP514x driver becomes compliant to this new
> model. I would like to be in sync with this activity as and when it happens.
> So please keep me in the loop.
>
> Please review these patches and let me know your comments so that I can go
> ahead and submit the same to v4l2 mailing list. I am also attaching a sample
> loopback application to this email so that you could see it working.
>
> Regards,
>
> Murali Karicheri
> Software Design Engineer
> Texas Instruments Inc.
> Germantown, MD 20874
> Phone : 301-515-3736
> email: [email protected][cid:[email protected]]
>
>
I have one comment that also refers to the new DM646x driver that was send to
the list for review, which is why I CC-ed this to Chaithrika as well:
The DM335/DM6446 adds the following files:
create mode 100644 drivers/media/video/davinci/ccdc_davinci.c
create mode 100644 drivers/media/video/davinci/ccdc_davinci.h
create mode 100644 drivers/media/video/davinci/vpfe_capture.c
create mode 100644 drivers/media/video/davinci/ccdc_dm355.c
create mode 100644 drivers/media/video/davinci/ccdc_dm355.h
create mode 100644 include/media/davinci/vpfe_capture.h
create mode 100644 include/media/davinci/vpfe_types.h
create mode 100644 include/media/davinci/ccdc_common.h
create mode 100644 include/media/davinci/ccdc_hw_device.h
DM646x adds these:
create mode 100644 drivers/media/video/davinci/dm646x_display.c
create mode 100644 drivers/media/video/davinci/vpif.c
create mode 100644 include/media/davinci/dm646x_display.h
create mode 100644 include/media/davinci/vpif.h
These names are confusing. The common style is to prefix each file with the
name of the device. That way it is immediately clear which sources belong
to which device.
So use dm355_ccdc.[ch], dm6446_capture.c and dm646x_vpif.c, etc.
Also note that abbreviations like 'vpif', 'vpfe', etc. should be explained
at the top of the header or source. When you are working with these drivers
every day you forget that not everyone knows what it means :-)
Unless you think it is really important I am not going to review these
drivers. I suggest that you watch my review of the dm646x and fix any
issues that will also apply to this driver before it comes up for review
on the linux-media list.
I have only so much time, and reviewing both on short notice is a bit too
much :-)
Regards,
Hans
--
Hans Verkuil - video4linux developer - sponsored by TANDBERG
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
