Laurent Pinchart <[email protected]> writes: > Hi Kevin, > > On Thursday 26 March 2009 23:07:16 Kevin Hilman wrote: >> [ TI internal-only lists dropped ] >> >> <[email protected]> writes: >> > Add platform related changes for vpfe capture driver on DM355 >> > >> > Signed-off-by: Murali Karicheri <[email protected]> >> >> [...] >> >> > static struct platform_device *davinci_evm_devices[] __initdata = { >> > &dm355evm_dm9000, >> > &davinci_nand_device, >> > @@ -190,6 +273,8 @@ static struct davinci_uart_config uart_config >> > __initdata = { static void __init dm355_evm_map_io(void) >> > { >> > davinci_map_common_io(); >> > + /* setup input configuration for VPFE input devices */ >> > + setup_vpfe_input_config(&vpfe_capture_inputs); >> >> This is the same function name as in dm644x, so this naming cannot work >> when support for both platforms is built into the same kernel. >> >> Might I recommend building with 'davinci_all_defconfig' so that these >> naming problems get exposed at compile time. >> >> I suggest you use the names dm355_setup_video(...) and >> dm644x_setup_video(...) > > If I'm not mistaken patches [3/7] and [4/7] can't be both compiled in the > kernel either as they export identically named symbols. >
Good catch! I hadn't noted that and hadn't tried compiling everything into the kernel. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
