From: David Brownell [mailto:[email protected]]
Sent: Monday, April 13, 2009 8:43 PM
>
> On Friday 10 April 2009, [email protected] wrote:
> > This issue is resolved by using a 2-byte extra offset in the packet
> buffer.
>
> Isn't the issue that NET_IP_ALIGN is supposed to resolve,
> when properly used by network drivers?

Looking at the documentation for that macro, drivers are supposed to call 
skb_reserve() with NET_IP_ALIGN as argument. The patch is doing the same, just 
not using the macro NET_IP_ALIGN.

Maybe I will define the EMAC_L3_ALIGN macro as

#define EMAC_L3_ALIGN(size)    ((NET_IP_ALIGN - (size)) & 0x3)

to be more clear?

Thanks,
Sekhar
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to