> > Isn't the issue that NET_IP_ALIGN is supposed to resolve, > > when properly used by network drivers? > > Looking at the documentation for that macro, drivers are supposed > to call skb_reserve() with NET_IP_ALIGN as argument. The patch is > doing the same, just not using the macro NET_IP_ALIGN. > > Maybe I will define the EMAC_L3_ALIGN macro as > > #define EMAC_L3_ALIGN(size) ((NET_IP_ALIGN - (size)) & 0x3) > > to be more clear?
I'm actually wondering why the EMAC_L3_ALIGN macro is needed at all. Doesn't NET_IP_ALIGN -- used correctly -- resolve the issue completely? See how other drivers are doing it. You're allocating an skb, and reserving some "extra" space at the beginning. The normal procedure is more or less to reserve NET_IP_ALIGN bytes, to achieve proper alignment. _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
