On Monday 11 May 2009, Kevin Hilman wrote:
> /* temporarily mask (level sensitive) parent IRQ */
> + desc->chip->mask(irq);
> desc->chip->ack(irq);
> while (1) {
That looks like a clear bugfix to me ... even makes the code
match the comment! Do any of the other parts of this patch
really matter? I'd send that part upstream, by itself.
(Minor nit, it might be good to have the intc code provide
a mask_ack method. It could probably save a dozen or two
instructions in the IRQ path. Then use that method here.)
I did some light testing, without lockdep, adding just that
one line: nuttcp loads. No nastygrams about tx timeouts.
On the other hand, since that dm9000 irq bugfix merged, I've
had a *harder* time seeing those bugs in any case.
- Dave
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
