On Tue, Aug 11, 2009 at 04:31:38, Kevin Hilman wrote: > Sekhar Nori <[email protected]> writes: > > > add basic CPUFreq support for DA850/OMAP-L138 > > > > Currently, frequency scaling only on PLL0 is supported. No scaling of PLL1 > > or voltage levels as yet. > > > > Peripherals like MMC/SD which have a clock input synchronous with > > ARM clock will not work well since the clock will change behind their backs. > > Support for notification to such devices to adjust themselves to the > > new frequency will be added in later patches. Current defconfigs keep > > CPUFreq disabled so it will not affect normal operation. > > > > The patch moves Async3 clock source to PLL1 so that frequency scaling > > on PLL0 does not affect those peripherals. Without this the console on UART2 > > goes for a toss the moment CPUFreq kicks in. > > Can you break this change of ASYNC3 modules out into a separate patch? > > Also, I'd rather see this done in a function in da850.c that changes > the parents of these clocks instead of changing them statically. This > way, when other clocks in ASYNC3 are added, this function will need to > be updated.
Agreed to this and all other comments on the patch set. Will post updated patches soon. Thanks, Sekhar _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
