Hello.
Miguel Aguilar wrote:
From: Miguel Aguilar <miguel.agui...@ridgerun.com>
This patch was tested on a DM365 EVM rev c, in both USB modes: Host
and Gadget.
Signed-off-by: Miguel Aguilar <miguel.agui...@ridgerun.com>
diff --git a/arch/arm/mach-davinci/board-dm365-evm.c
b/arch/arm/mach-davinci/board-dm365-evm.c
index f6adf79..3a0d404 100644
--- a/arch/arm/mach-davinci/board-dm365-evm.c
+++ b/arch/arm/mach-davinci/board-dm365-evm.c
@@ -38,6 +38,7 @@
#include <mach/common.h>
#include <mach/mmc.h>
#include <mach/nand.h>
+#include <mach/gpio.h>
static inline int have_imager(void)
@@ -270,6 +271,14 @@ static void dm365evm_mmc_configure(void)
davinci_cfg_reg(DM365_SD1_DATA0);
}
+static void dm365evm_usb_configure(void)
+{
+ davinci_cfg_reg(DM365_GPIO33);
Can fail.
[MA]Can you be more specific?. All of the davinci cfg regs are defined
in this way over the DaVinci platforms.
This function can fail, and you're not handling this.
+ gpio_request(33, "usb");
Can also fail.
[MA] What you mean is that error handling is missing?.
Yes.
WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
