Miguel,
I am in the process of re-structuring the DaVinci USB platform/board specific
functionality. I am delayed a bit as I had to work on fixing a DMA related
issue on DaVinci platforms. Will work on the re-structure by this weekend.
Though it would be difficult to give a clear answer on how the partition would
be done but as discussed in Kevin's thread the board specific details would be
populated external to musb module. Musb module would just be invoking the
related functionalities in a generic way.
regards
swami
________________________________________
From: davinci-linux-open-source-boun...@linux.davincidsp.com
[davinci-linux-open-source-boun...@linux.davincidsp.com] On Behalf Of Miguel
Aguilar [miguel.agui...@ridgerun.com]
Sent: Wednesday, September 09, 2009 12:51 AM
To: Sergei Shtylyov
Cc: santiago.nu...@ridgerun.com; todd.fisc...@ridgerun.com;
davinci-linux-open-source@linux.davincidsp.com; clark.bec...@ridgerun.com
Subject: Re: [PATCH 2/2] DaVinci: DM365: Enable USB in DM365 EVM
Hi,
Two questions:
What do you think about to pass the set_vbus function from board specific file
to the USB driver by using "(*set_vbus)(struct device *dev, int is_on)" member
of the musb_hdrc_platform_data?
What is the better way to handle the clock selection in the board file?
Thanks,
Miguel Aguilar
Sergei Shtylyov wrote:
> Hello.
>
> Miguel Aguilar wrote:
>
>>>> From: Miguel Aguilar <miguel.agui...@ridgerun.com>
>
>>>> This patch was tested on a DM365 EVM rev c, in both USB modes: Host
>>>> and Gadget.
>
>>>> Signed-off-by: Miguel Aguilar <miguel.agui...@ridgerun.com>
>
>>>> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c
>>>> b/arch/arm/mach-davinci/board-dm365-evm.c
>>>> index f6adf79..3a0d404 100644
>>>> --- a/arch/arm/mach-davinci/board-dm365-evm.c
>>>> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
>>>> @@ -38,6 +38,7 @@
>>>> #include <mach/common.h>
>>>> #include <mach/mmc.h>
>>>> #include <mach/nand.h>
>>>> +#include <mach/gpio.h>
>>>>
>>>>
>>>> static inline int have_imager(void)
>>>> @@ -270,6 +271,14 @@ static void dm365evm_mmc_configure(void)
>>>> davinci_cfg_reg(DM365_SD1_DATA0);
>>>> }
>>>>
>>>> +static void dm365evm_usb_configure(void)
>>>> +{
>>>> + davinci_cfg_reg(DM365_GPIO33);
>
>>> Can fail.
>
>> [MA]Can you be more specific?. All of the davinci cfg regs are defined
>> in this way over the DaVinci platforms.
>
> This function can fail, and you're not handling this.
>
>>>> + gpio_request(33, "usb");
>
>>> Can also fail.
>
>> [MA] What you mean is that error handling is missing?.
>
> Yes.
>
> WBR, Sergei
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
