Hello.

Mark A. Greer wrote:

From: David A. Griego <[email protected]>

Add pinmux settings, etc. to enable the MMC/SC hardware.

Signed-off-by: David A. Griego <[email protected]>
Signed-off-by: Mark A. Greer <[email protected]>
[...]
diff --git a/arch/arm/mach-davinci/board-da830-evm.c 
b/arch/arm/mach-davinci/board-da830-evm.c
index 39711c1..69a791a 100644
--- a/arch/arm/mach-davinci/board-da830-evm.c
+++ b/arch/arm/mach-davinci/board-da830-evm.c
@@ -23,6 +23,7 @@
 #include <mach/irqs.h>
 #include <mach/cp_intc.h>
 #include <mach/mux.h>
+#include <mach/gpio.h>
 #include <mach/da8xx.h>
 #include <mach/asp.h>
@@ -83,6 +84,38 @@ static struct snd_platform_data da830_evm_snd_data = {
        .rxnumevt       = 1,
 };
+/*
+ * GPIO2[1] is used as MMC_SD_WP and GPIO2[2] as MMC_SD_INS.
+ */
+static const short da830_evm_mmc_sd_pins[] = {
+       DA830_MMCSD_DAT_0, DA830_MMCSD_DAT_1, DA830_MMCSD_DAT_2,
+       DA830_MMCSD_DAT_3, DA830_MMCSD_DAT_4, DA830_MMCSD_DAT_5,
+       DA830_MMCSD_DAT_6, DA830_MMCSD_DAT_7, DA830_MMCSD_CLK,
+       DA830_MMCSD_CMD,   DA830_GPIO2_1,     DA830_GPIO2_2,

There was no sense in overriding the whole "standard" pin list -- you could just have created an extra list consisting of 2 GPIO pins...

+       -1
+};
+
+static int da830_evm_mmc_get_ro(int index)
+{
+       int val, status, gpio_num = 33;

There's GPIO_PIN() macro now, so you could have used GPIO_PIN(2, 1) instead. It's not clear why you useed a variable at all -- instead of a macro...

+
+       status = gpio_request(gpio_num, "MMC WP\n");
+       if (status < 0) {
+               pr_warning("%s can not open GPIO %d\n", __func__, gpio_num);
+               return 0;
+       }
+       gpio_direction_input(gpio_num);
+       val = gpio_get_value(gpio_num);
+       gpio_free(gpio_num);
+       return val;
+}
+
+static struct davinci_mmc_config da830_evm_mmc_config = {
+       .get_ro                 = da830_evm_mmc_get_ro,
+       .wires                  = 4,

   Doesn't DA830 EVM have 8-wire MMC interface?

WBR, Sergei

_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

Reply via email to