On Fri, Sep 18, 2009 at 08:42:09PM +0400, Sergei Shtylyov wrote:
>> diff --git a/arch/arm/mach-davinci/board-da830-evm.c
>> b/arch/arm/mach-davinci/board-da830-evm.c
>> +/*
>> + * GPIO2[1] is used as MMC_SD_WP and GPIO2[2] as MMC_SD_INS.
>> + */
>> +static const short da830_evm_mmc_sd_pins[] = {
>> + DA830_MMCSD_DAT_0, DA830_MMCSD_DAT_1, DA830_MMCSD_DAT_2,
>> + DA830_MMCSD_DAT_3, DA830_MMCSD_DAT_4, DA830_MMCSD_DAT_5,
>> + DA830_MMCSD_DAT_6, DA830_MMCSD_DAT_7, DA830_MMCSD_CLK,
>> + DA830_MMCSD_CMD, DA830_GPIO2_1, DA830_GPIO2_2,
>
> There was no sense in overriding the whole "standard" pin list -- you
> could just have created an extra list consisting of 2 GPIO pins...
It seems better to have the exact list here to its obvious what's being
set up. If I set up the std list then changed it, its less obvious
what's being changed (IMHO).
>> +static int da830_evm_mmc_get_ro(int index)
>> +{
>> + int val, status, gpio_num = 33;
>
> There's GPIO_PIN() macro now, so you could have used GPIO_PIN(2, 1)
> instead. It's not clear why you useed a variable at all -- instead of a
> macro...
I pretty much copied it from an internal file and didn't really look at
it closely. I'll go though it closer. Thanks.
>> +static struct davinci_mmc_config da830_evm_mmc_config = {
>> + .get_ro = da830_evm_mmc_get_ro,
>> + .wires = 4,
>
> Doesn't DA830 EVM have 8-wire MMC interface?
It supports 1-bit, 4-bit & 8-bit modes but 8-bit mode isn't supported by
the driver yet. IIUC, its on TI's todo list.
Mark
--
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
