Sergei Shtylyov <[email protected]> writes: > Hello, I wrote: > >>> Add support for the Sharp LCD035Q3DG01 graphical LCD. This >>> requires a minor interface change to da8xx_register_lcdc() >>> so that the board code can pass in the platform_data which >>> describes the lcd controller that's to be used. > >>> Signed-off-by: Mark A. Greer <[email protected]> > >> [...] > >>> diff --git a/arch/arm/mach-davinci/devices-da8xx.c >>> b/arch/arm/mach-davinci/devices-da8xx.c >>> index 0102e0a..5595613 100644 >>> --- a/arch/arm/mach-davinci/devices-da8xx.c >>> +++ b/arch/arm/mach-davinci/devices-da8xx.c >>> @@ -21,7 +21,6 @@ >>> #include <mach/common.h> >>> #include <mach/time.h> >>> #include <mach/da8xx.h> >>> -#include <video/da8xx-fb.h> >>> #include "clock.h" >>> @@ -381,10 +380,16 @@ static struct lcd_ctrl_config lcd_cfg = { >>> .raster_order = 0, >>> }; >>> -static struct da8xx_lcdc_platform_data da850_evm_lcdc_pdata = { >>> - .manu_name = "sharp", >>> - .controller_data = &lcd_cfg, >>> - .type = "Sharp_LK043T1DG01", >>> +struct da8xx_lcdc_platform_data sharp_lcd035q3dg01_pdata = { >>> + .manu_name = "sharp", >>> + .controller_data = &lcd_cfg, >>> + .type = "Sharp_LCD035Q3DG01", >>> +}; >>> + >>> +struct da8xx_lcdc_platform_data sharp_lk043t1dg01_pdata = { >>> + .manu_name = "sharp", >>> + .controller_data = &lcd_cfg, >>> + .type = "Sharp_LK043T1DG01", >>> }; > >> It's not clear why the platfrom devices are declared here and not >> in the board file...
I had the same question initially, but assumed they were there so they could be shared across different boards. > Oh, this is already committed... Kevin, could you allow more time > on the patch feedback next time? Heh, I've never been accused of applying things too quickly before. Normally, I'm too slow. ;) Yes, it's committed to davinci git, but no reason it cant be reworked before going upstream if needed. Kevin _______________________________________________ Davinci-linux-open-source mailing list [email protected] http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
