On Wed, Sep 23, 2009 at 12:14:24AM +0400, Sergei Shtylyov wrote:
> Hello.
>
> Mark A. Greer wrote:
>> On Fri, Sep 18, 2009 at 09:05:56PM +0400, Sergei Shtylyov wrote:
>>
>>
>>>> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
>>>>
>>
>>
>>>> +config DA830_UI_LCD
>>>> + bool "LCD"
>>>> + help
>>>> + Say Y here to use the LCD as a framebuffer or simple character
>>>> + display.
>>>> +
>>>> +endchoice
>>>>
>>> Certainly my addition thu the help text was somewhat reworded...
>>>
>>
>> Yes I reworded it. What is your issue?
>>
>
> No issues, just noticed the rewording...
OK
>>>> @@ -175,6 +206,17 @@ static __init void da830_evm_init(void)
>>>> if (ret)
>>>> pr_warning("da830_evm_init: mmc/sd registration failed: %d\n",
>>>> ret);
>>>> +
>>>> +#ifdef CONFIG_DA830_UI_LCD
>>>> + ret = da8xx_pinmux_setup(da830_lcdcntl_pins);
>>>> + if (ret)
>>>> + pr_warning("da830_evm_init: lcdcntl mux setup failed: %d\n",
>>>> + ret);
>>>> +
>>>> + ret = da8xx_register_lcdc(&sharp_lcd035q3dg01_pdata);
>>>>
>>> It's again not clear why board specific LCD platfrom data ended up
>>> in devices-da8xx.c
>>>
>>
>> Firstly, that's where the definition for sharp_lk043t1dg01_pdata
>> already was so I simply added to what already existed. Secondly,
>> the lcd definitions are [more-or-less] board agnostic, not board specific.
>>
>
> That is what I'm finding most strange. How the LCD controller choice
> (with it chosen specifically for implementing the board) can be board
> agnostic?
> AFAIU, this is as board specific as e.g. a NAND chip, yet you put thr
> NAND platfrom data into the board file despite the possibility of the
> same NAND chip being used on several different boards...
You make a good point but you missed my first point :)
IOW, the initial patch put it in devices-da8xx.c.
Feel free to change it, I have no strong preference.
Mark
--
_______________________________________________
Davinci-linux-open-source mailing list
[email protected]
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
